https://bugzilla.redhat.com/show_bug.cgi?id=877396

--- Comment #2 from Mattias Ellert <mattias.ell...@fysast.uu.se> ---
(In reply to Björn Esser from comment #1)

>  * `BuildRoot: ...` and `rm -rf %{buildroot}` is obsoleted

Also this package is intended for EPEL 5.

>  * use `%make_install` instead `make install DESTDIR=...`

Not mandated by guidelines, and not possible for EPEL 5.

>  * -devel should have Requires: %{name}%{?_isa} = %{version}-%{release}

Fixed.

>  * undefined-non-weak-symbol /usr/lib64/libHepMCfio.so.4.0.0 hepevt_
>    Ask upstream to solve this in next version, pleas

This is like this by design, and is not likely to change. There is no
one-size-fits-all for the hepevt array. The application using the library
should define it the size it needs. If it is predefined in the library users of
the library can not change its size.

New version:

Spec URL: http://www.grid.tsl.uu.se/review/HepMC.spec
SRPM URL: http://wwwgrid.tsl.uu.se/review/HepMC-2.06.09-2.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=IP4pIpqytf&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to