https://bugzilla.redhat.com/show_bug.cgi?id=966201

Antonio Trande <anto.tra...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anto.tra...@gmail.com

--- Comment #1 from Antonio Trande <anto.tra...@gmail.com> ---
Hi David.

- If your package is "just" for Fedora/EPEL6, you don't need of

  rm -rf %{buildroot}

  entire %clean section
(http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean)

  %defattr(-,root,root,-)
(http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions)

- In the %file section (and in the %description) , the macro %{name} use is
most appropriate.

- README file says

> `tnftp' is a `port' of the NetBSD FTP client to other systems.
> See http://www.NetBSD.org/ for more details about NetBSD.

I think http://www.NetBSD.org/  is fitting as URL:, maybe also with a comment
about why.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=GPXD7uIRE2&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to