https://bugzilla.redhat.com/show_bug.cgi?id=967568
--- Comment #3 from Wolfgang Ulbrich <chat-to...@raveit.de> ---
Thank you Eduardo for reviewing.
(In reply to Eduardo Echeverria from comment #2)
> Hi @Wolfgang, there are some issues:
>
> - The virtual provides of lang package aren't sane, since the subpackage not
> exist as such
> - Likewise with the Obsoletes
> - Remove %{name}-lang = %{version}-%{release} (for the same reasons)
I will remove the unnecessary virtual provides, the obsoleting line i need to
updating the package from my external additional repo.
Here the package contains a -lang subpackage.
The require i forgot to remove.
>
> - There are some missing Requires, according to my research:
> * mozo (replacing alacarte)
Thanks for you hint, i will do it.
> * Gconf2
Mintmenu is ported to gsettings, and dconf is called with mate-panel and other
MATE packages.
> * mate-deskbar-applet (but can't find it in the packages database)
This was former needed for the keybindings to the superL key for opening the
menu. Upstream has add a own libary for this.
https://github.com/linuxmint/mintmenu/commit/cab7f82899180e1bde54b5b51c0e355694c605e8
>
> Please add comment explain the multiple licensing scenario.
> https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/
> LicensingGuidelines#Multiple_Licensing_Scenarios
> I understand that the only file that is under MIT is "keybinding.py"
Ok, i will do it.
>
> - the package doesn't contains a boilerplate of the license GPLv2+, ask to
> upstream for include it
I'm not shure if i understand you correct (sorry my bad english), you mean a
COPYING file. Shure i can open a issue report at github.
>
> Cheers
cheers,
Wolfgang
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=n3pGv0lILo&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
