https://bugzilla.redhat.com/show_bug.cgi?id=964318
Volker Fröhlich <volke...@gmx.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |volke...@gmx.at
--- Comment #1 from Volker Fröhlich <volke...@gmx.at> ---
Why did you call it python-vm-builder and not python-vmbuilder, which is closer
to the upstream name?
The release tag in the changelog is not complete.
Either add the commands necessary to create the tarball or consider to use the
tarball from https://launchpad.net/vmbuilder/+download, if feasible.
Ask them to include a license file.
I think you can create a richer description than the one present.
No need to purge the build root in the install section, no need to define
python_sitelib, see
https://fedoraproject.org/wiki/EPEL:Packaging#Prepping_BuildRoot_For_.25install
and https://fedoraproject.org/wiki/Packaging:Python#Macros
What's the upstream status of that patch? Also use the name macro on Patch0.
I wonder if the VM templates should really go to /etc. FHS defines /etc to be
used for "Host-specific system configuration". I'm not sure if that's the case
here. However, you're not owning the directory %{_sysconfdir}/vmbuilder.
%{python_sitelib}/VMBuilder/ is a lot more concrete than %{python_sitelib}/*
Please install the manpage that ships along and consider to include the
examples directory as documentation.
BuildRequires should be "python2-devel" instead of "python-devel". Do know
whether it works with Python 3?
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=riY3dMbodH&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
