https://bugzilla.redhat.com/show_bug.cgi?id=949324
--- Comment #13 from Jaroslav Škarvada <jskar...@redhat.com> --- New files: Spec URL: http://fedorapeople.org/~jskarvad/oath-toolkit/oath-toolkit.spec SRPM URL: http://fedorapeople.org/~jskarvad/oath-toolkit/oath-toolkit-2.0.2-3.fc18.src.rpm (In reply to David Woodhouse from comment #12) > Working through the rest of the review guidelines... should the pam_oath > package require %{_libdir}/security (or 'pam')? > Yes, I forget :) Fixed. > And should the Requires: Requires: libpskc = %{version}-%{release} in > libpskc-devel actually be Requires: libpskc{?_isa} = %{version}-%{release} > (and other packages likewise)? > Probably, they reference arch libs, so I fixed both devel packages. Probably no need for other packages. > In addition to the rpmlint warnings in comment 11, I also see the following: > > libpskc.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libpskc.so.0.0.1 /lib64/libltdl.so.7 > libpskc.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libpskc.so.0.0.1 /lib64/libxslt.so.1 > libpskc.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libpskc.so.0.0.1 /lib64/libz.so.1 > libpskc.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libpskc.so.0.0.1 /lib64/libdl.so.2 > libpskc.x86_64: W: unused-direct-shlib-dependency > /usr/lib64/libpskc.so.0.0.1 /lib64/libm.so.6 > I was unable to reproduce this (f18/f19), but to be sure I linked it with --as-needed. Man pages also fixed, patch sent upstream. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=i9SFYZbcGB&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
