https://bugzilla.redhat.com/show_bug.cgi?id=841266
--- Comment #16 from Jason Tibbitts <ti...@math.uh.edu> --- So I downloaded and built this; anyone who is still interested after nearly a year certainly deserves a review. However, I immediately noticed a few issues: The package doesn't build with the mandatory compiler flags. If that's a regular autoconf-generated script (and it sure looks like it is), why not use the usual %configure macro to call it, so that everything gets set and passed correctly? Did you look at the rpmlint output at all? I see a bunch of stuff which is trivially fixable and some other stuff I don't understand at all. plink-debuginfo.x86_64: E: debuginfo-without-sources This comes from not building with the mandatory compiler flags. (-g isn't there, so no debug info was compiled in.) plink.x86_64: W: manual-page-warning /usr/share/man/man1/plink.1.gz 28: warning: numeric expression expected (got a tab character) A whole bunch of these which I don't understand. Generally you should not compress manpages; rpm will do it automatically, and will use the proper compression system if we decide to switch from gzip in the future. plink.src: W: summary-not-capitalized C whole genome association analysis toolset Should capitalize the summary. plink.src:28: W: configure-without-libdir-spec The configure script should be called via %configure if it is autoconf-generated. plink.src:10: W: mixed-use-of-spaces-and-tabs (spaces: line 10, tab: line 1) Please be consistent with indentation. plink.src: W: file-size-mismatch plink-1.07-src.zip = 692437, http://pngu.mgh.harvard.edu/~purcell/plink/dist/plink-1.07-src.zip = 2257297 So, what happened here? The file in the src.rpm is pretty much completely different than what's at the upstream web site. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QKuXXTosyT&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
