https://bugzilla.redhat.com/show_bug.cgi?id=976793
--- Comment #2 from Michael Schwendt <mschwe...@gmail.com> --- This will be non-trivial to review, and I dunno whether I will find enough time this weekend to do everything. How deeply have you reviewed the package already? rpmlint tells: libLunchbox.src: E: description-line-too-long C Lunchbox is C++ library for multi-threaded programming, providing OS abstraction, > Name: libLunchbox > Group: Development/Libraries "System Environment/Libraries" is the group for the run-time library base packages. > License: LGPLv2 It's more than that. Lunchbox-1.4.0/lunchbox/md5/md5.cc and md5.hh : This is a copied MD5 implementation with an own license by RSA Data Security Inc. And it's one not mentioned at https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries already. Lunchbox-1.4.0/lunchbox/atomic.h : Distributed under the Boost Software License, Version 1.0. Lunchbox-1.4.0/lunchbox/indexIterator.h : LGPLv3 Lunchbox-1.4.0/lunchbox/lfVector.h : LGPLv3 Lunchbox-1.4.0/lunchbox/lfVectorIterator.h : LGPLv3 Lunchbox-1.4.0/lunchbox/serializable.h : LGPLv3 Lunchbox-1.4.0/tests/lfVector.cpp : LGPLv3 Lunchbox-1.4.0/tests/servus.cpp : LGPLv3 https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Clarification > BuildRequires: cmake, doxygen, graphviz build.log contains a few "could not find …" messages. Are any of them [optional] missing BuildRequires? > %package devel > Requires: pkgconfig, cmake Both should be dropped. There's an automatic dependency on /usr/bin/pkg-config already. And this -devel package certainly does not strictly require cmake, because e.g. it contains a pkgconfig file and can be used without cmake. Feel free to include the cmake directories based on this in the guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function > %package doc > Requires: %{name} = %{version}-%{release} Separate documentation -doc packages typically don't require the base package. It should be possible to install documentation without having to install a program and all its dependencies. With a total size of just 76716 bytes, the files in this -doc package could stay in the -devel package. > %files > %{_datadir}/%{name} This tree belongs into the -devel package. drwxr-xr-x /usr/share/libLunchbox drwxr-xr-x /usr/share/libLunchbox/CMake -rw-r--r-- /usr/share/libLunchbox/CMake/options.cmake The path is broken afaics after you move the file in the %install section. $ cd Lunchbox-1.4.0 $ grep options.cmake * -R CMake/FindLunchbox.cmake: include("${LUNCHBOX_LIBRARY_DIRS}/../share/Lunchbox/CMake/options.cmake") CMakeLists.txt:install(FILES ${CMAKE_BINARY_DIR}/options.cmake lunchbox/configure.cmake:set(OPTIONS_CMAKE ${CMAKE_BINARY_DIR}/options.cmake) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Jom3OOeZ1f&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
