https://bugzilla.redhat.com/show_bug.cgi?id=927374

--- Comment #2 from Troy Dawson <tdaw...@redhat.com> ---
Spec URL: http://tdawson.fedorapeople.org/review/rubygem-rugged.spec
SRPM URL:
http://tdawson.fedorapeople.org/review/rubygem-rugged-0.16.0-1.fc20.src.rpm

-  libgit2 is bundled in the gem, it should be removed.
-- according to ext/rugged/extconf.rb if we have git2 and git2.h installed, it
will not use the bundled library.
-- Added BuildRequires: libgit2-devel which pulls in git2 and git2.h, so that
the bundled library isn't used during build.
-- We delete the bundled library so it isn't shipped.

- Permissions should be 755 for rugged.so
-- Fixed

- Duplicate rugged.so
-- Fixed (remove /usr/share/gems/gems/rugged-0.16.0/lib/rugged/rugged.so)

-  Mixed use of macros
-- Fixed (now consistently use %{buildroot}

- Run tests
-- Thank you for the testing syntax, I have put that in and it works.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=JIyd1ktaPH&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to