https://bugzilla.redhat.com/show_bug.cgi?id=658754
--- Comment #24 from Michael Schwendt <mschwe...@gmail.com> ---
Just a drop by comment:
> 2. Please, don't define the Release tag like "%{release}%{?dist}",
> just replace it with 1%{?dist} is easy, right? You use about 30
> chars space to define a macro of "1", jesus..
The much better reason why not to complicate the Release tag is that the
%{release} variable is defined by the Release tag already. You've had
$ grep release cubrid.spec
%define release 4
Release: %{release}%{?dist}
and afterwards, %release would not be "4" anymore, but would get the value of
whatever the full "Release" tag expands to, e.g. "4.fc19" depending on %dist.
Similarly for variables defined by tags like Name -> %{name}, Version ->
%{version}. Redefining those variables can make the spec file less clear.
> %define libdir %{_prefix}/lib
> …
> %{libdir}/libcmstat.so
> %{libdir}/libbrokeradmin.so.%{cubrid_version}
> %{libdir}/libbrokeradmin.so.8
> …
Even if a future version will fix that indeed, till then it won't be acceptable
to store arch-specific libs in /usr/lib instead of the default %{_libdir}.
> %{libdir}/libbrokeradmin.la
libtool archives ->
https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries
> %{libdir}/libcascci.so
https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=egISuvu9ei&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
