Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=592137

Aditya Patawari <adima...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adima...@gmail.com

--- Comment #6 from Aditya Patawari <adima...@gmail.com> 2010-05-17 07:14:54 
EDT ---
Informal Review

rpmlint output:
koffice-kivio.src: W: spelling-error Summary(en_US) flowcharting -> flow
charting, flow-charting, flowchart
koffice-kivio.src: W: spelling-error %description -l en_US flowcharting -> flow
charting, flow-charting, flowchart
Error checking signature of
../../Downloads/koffice-kivio-1.6.3-31.trinity.20100511svn.fc13.src.rpm:
../../Downloads/koffice-kivio-1.6.3-31.trinity.20100511svn.fc13.src.rpm: (SHA1)
DSA sha1 md5 (GPG) NOT OK (MISSING KEYS:GPG#1634f842)
koffice-kivio.src: W: invalid-url Source1: kivio-translations-20100511.tar.bz2
koffice-kivio.src: W: invalid-url Source0: koffice-trinity-20100511.tar.bz2
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.
+ BuildRequires correct
+ defattr present and correct
+ %doc is fine
+ BuildRoot is correct
{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+ desktop files are properly validated.
+ Package is code and has permissible content.
+ Package owns all the directories it creates.
- md5sum not verified as the source was tarred manually from the svn snapshot
- There is no step-by-step guide on how to get the source tarball.

The package looks fine, has to reviewed by a packager.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to