https://bugzilla.redhat.com/show_bug.cgi?id=976714
Sergio Pascual <sergio.pa...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(sergio.pasra@gmai |
|l.com) |
--- Comment #11 from Sergio Pascual <sergio.pa...@gmail.com> ---
Spec URL: http://guaix.fis.ucm.es/~spr/python-scikit-learn.spec
SRPM URL:
http://guaix.fis.ucm.es/~spr/python-scikit-learn-0.13.1-3.fc19.src.rpm
(In reply to Marcelo Barbosa from comment #10)
> Sergio,
>
> I'm reviewing your package, please check some issues:
>
> - Large documentation must go in a -doc subpackage.
> Note: Documentation size is 2222080 bytes in 280 files.
> See:
> http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
>
I have removed documentation (for the moment), html build fails with sphinx and
our our current docutils
> - Setting Variables with a only one request for line , example:
> BuildRequires: python2-devel
> BuildRequires: numpy
> See:
> https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/
> Guidelines#BuildRequires
Done
>
> - Review your licence, i believe mix licences in this package. I don't see a
> BSD license at all.
>
> "License field in the package spec file matches the actual license.
> Note: Checking patched sources after %prep for licenses. Licenses found:
> "BSD (3 clause)", "BSD (2 clause)", "Unknown or generated". 492 files
> have unknown license. Detailed output of licensecheck in
> /home/marcelo.barbosa/rpmbuild/SOURCES/reviews/976714-python-scikit-
> learn/licensecheck.txt"
>
> See:
> http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
> See:
> https://fedoraproject.org/wiki/Packaging:
> LicensingGuidelines#Multiple_Licensing_Scenarios
>
No License file is shipped, but the web page says "BSD 3 clauses"
The different licenses are both BSD (either 3 clauses or 2 clauses) as per
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses
so the total license is BSD and BSD == BSD
I have added a comment below License in the specfile
> - Package consistently uses macro is (instead of hard-coded directory names).
> See:
> https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/
> Guidelines#Macros
>
Where is this?
> - Please see devel files unversioned:
> Unversioned so-files
> --------------------
> python-scikit-learn:
> /usr/lib64/python2.7/site-packages/sklearn/__check_build/_check_build.so
> python-scikit-learn: /usr/lib64/python2.7/site-packages/sklearn/_hmmc.so
> python-scikit-learn:
> /usr/lib64/python2.7/site-packages/sklearn/cluster/_hierarchical.so
> python-scikit-learn:
> /usr/lib64/python2.7/site-packages/sklearn/cluster/_k_means.so
> python-scikit-learn:
> /usr/lib64/python2.7/site-packages/sklearn/datasets/_svmlight_format.so
> python-scikit-learn:
> /usr/lib64/python2.7/site-packages/sklearn/ensemble/_gradient_boosting.so
> python-scikit-learn:
> /usr/lib64/python2.7/site-packages/sklearn/feature_extraction/_hashing.so
> python-scikit-learn:
> /usr/lib64/python2.7/site-packages/sklearn/linear_model/cd_fast.so
> python-scikit-learn:
> /usr/lib64/python2.7/site-packages/sklearn/linear_model/sgd_fast.so
> python-scikit-learn:
> /usr/lib64/python2.7/site-packages/sklearn/metrics/cluster/
> expected_mutual_info_fast.so
> python-scikit-learn:
> /usr/lib64/python2.7/site-packages/sklearn/metrics/pairwise_fast.so
> python-scikit-learn:
> /usr/lib64/python2.7/site-packages/sklearn/neighbors/ball_tree.so
> python-scikit-learn:
> /usr/lib64/python2.7/site-packages/sklearn/svm/liblinear.so
> python-scikit-learn: /usr/lib64/python2.7/site-packages/sklearn/svm/libsvm.so
> python-scikit-learn:
> /usr/lib64/python2.7/site-packages/sklearn/svm/libsvm_sparse.so
> python-scikit-learn: /usr/lib64/python2.7/site-packages/sklearn/tree/_tree.so
> python-scikit-learn:
> /usr/lib64/python2.7/site-packages/sklearn/utils/arraybuilder.so
> python-scikit-learn:
> /usr/lib64/python2.7/site-packages/sklearn/utils/arrayfuncs.so
> python-scikit-learn:
> /usr/lib64/python2.7/site-packages/sklearn/utils/graph_shortest_path.so
> python-scikit-learn:
> /usr/lib64/python2.7/site-packages/sklearn/utils/lgamma.so
> python-scikit-learn:
> /usr/lib64/python2.7/site-packages/sklearn/utils/murmurhash.so
> python-scikit-learn:
> /usr/lib64/python2.7/site-packages/sklearn/utils/random.so
> python-scikit-learn:
> /usr/lib64/python2.7/site-packages/sklearn/utils/seq_dataset.so
> python-scikit-learn:
> /usr/lib64/python2.7/site-packages/sklearn/utils/sparsefuncs.so
> python-scikit-learn:
> /usr/lib64/python2.7/site-packages/sklearn/utils/sparsetools/_csgraph.so
> python-scikit-learn:
> /usr/lib64/python2.7/site-packages/sklearn/utils/weight_vector.so
> See:
> https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/
> Guidelines#Devel_Packages
>
These are not .so files of a devel package, they are Python extensions, that
happen to be dynamic libraries ending with .so
> Marcelo Barbosa (firemanxbr)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=scUNmNZwO5&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
