https://bugzilla.redhat.com/show_bug.cgi?id=984700
--- Comment #6 from Kevin Kofler <ke...@tigcc.ticalc.org> --- > + '%{cmake}' .. > /var/tmp/rpm-tmp.e633jH: line 35: fg: no job control Missing "BuildRequires: cmake". ("fg: no job control" is usually the result of an undefined RPM macro. RPM then leaves the macro unexpanded, so bash tries to interpret it as some job control thingy, which obviously fails.) > Something is wrong in the cmake, I see two periods. No, that is perfectly fine cmake command-line syntax. (CMake takes a directory on the command line, .. is the parent directory, which is what you want if you're building in a subdirectory.) > 3. I think you should choose tarball > https://github.com/sddm/sddm/archive/0.1.0.tar.gz > > as Source0 as this software will grow bigger and bigger. tar.gz or zip doesn't make much difference compression-wise, they're both using deflate as the algorithm. The tar.gz might be slightly smaller because it is always a solid archive (it first tars up everything and then compresses the whole thing as one file), but I don't expect a big difference. A tar.xz or at least tar.bz2 would be helpful size-wise, if github can deliver that (but I wouldn't recompress the upstream tarball if they only ship tar.gz, doing that is frowned upon because it makes it harder to verify authenticity). That said, I'd pick the tar.gz over the zip for other practical reasons, e.g. better support for unixy stuff such as symlinks, special permissions etc. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MjFRCOuc5X&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review