https://bugzilla.redhat.com/show_bug.cgi?id=988102
--- Comment #10 from Björn Esser <bjoern.es...@gmail.com> ---
(In reply to Christopher Meng from comment #8)
Thanks, for you remarks.
> This package is in my repo ;) I've packaged it.
>
> Issues besides Bjorn's:
>
> 1. Remove find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';'
>
> This is a old mistake by extutils years ago, it's fixed now.
Any clarifying link to this? For which dists this is fixed? Is el5 still
affected or are things fixed there, too?
As far as I see, this command will remove some unused and empty dirs, only.
Give me some helpful clues on this, please.
> 2. Why mark these as %doc:
>
> *.pod eg ?
Refering to mschwendt's comment #9: Why not? ;)
eg/ contains some brief examples, so it's really a should-be-in. *.pod is some
docs differing from man-page. It's kinda markdown; human-readable and
convertible to various formats with broad choice of different tools. So both
are %doc...
> And I didn't push it to fedora review because I can't test it with sybase
> server, can you test it?
Yes, temporary; if I need one, I can get one for a couple of hours ;)
> Thanks, and also please update your spec and srpm so we can review again.
The small two-line change, I mentioned, can be made by mcas on SCM-import, as
well. It's just important to have them made. ;)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=CN72SKAJhv&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
