https://bugzilla.redhat.com/show_bug.cgi?id=989859
--- Comment #4 from Christopher Meng <cicku...@gmail.com> --- (In reply to Volker Fröhlich from comment #3) > https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses -- > The license should read "BSD" in the spec file. Fixed. > The example program is not part of the main package. Thus I feel, the main > package description should not mention it. The summary of util says > "libsndfile". I think the description doesn't really fit the util subpackage > well either. Fixed. > Can you run the tests? No rules for test, can you ensure? > The xls2csv binary causes my build to break with an rpath issue. I build the library without any problem, not sure about yours, any logs? NEW SPEC URL: http://cicku.me/libxls.spec NEW SRPM URL: http://cicku.me/libxls-1.3.4-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kNg412FHWt&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
