https://bugzilla.redhat.com/show_bug.cgi?id=990624
--- Comment #3 from Igor Gnatenko <i.gnatenko.br...@gmail.com> ---
(In reply to Christopher Meng from comment #2)
> I recommend you to move %post{un} scripts below install section and above
> file's section.
fxd
(In reply to Haïkel Guémar from comment #1)
> quickies:
> * lacks a comment explaining how the tarball has been generated (either
> provide a script or a command-line)
Simple download
> * python wrapper not included
In future will deleted
> * tests (depending on the aforementioned python wrapper) missing too
In future will fixed
> * you should request upstream maintainer to add a license file in his
> repository (and release tarballs when they'll be available)
fxd
new spec: http://ignatenkobrain.fedorapeople.org/for-review/json-parser.spec
new srpm:
http://ignatenkobrain.fedorapeople.org/for-review/json-parser-1.0.0-1.df38ae7.fc19.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=LNL5hm3hx5&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
