https://bugzilla.redhat.com/show_bug.cgi?id=991314
--- Comment #3 from Joshua Small <techn...@lolware.net> --- Hi Christopher, Many thanks for this review. Going through your points: Name: Done. 0: I had a paragraph here, and rpmlint told me to write something smaller :p I think I've come up with a happy medium now. 1: It's definitely not an alpha release. I made a one line Makefile change from v1.1 to help this packaging process and called it 1.1a - apparently a bad move. I've just tagged a newer version as 1.12 which should resolve this issue. 2. Done. This was put here by the wizard. 3. Done. Definitely an improvement. 4. Done. However, I don't think it should have been there in the first place, so the .a file is no longer installed by "make install". This has been documented on my github page in the changenotes. Ironically, this is a revert to an earlier configuration, however, a packager for another distribution originally requested this. Hopefully I've addressed everything in one go. rpmlint only warns about spelling: [fedora@ip-172-31-20-108 rpmbuild]$ rpmlint ./SPECS/libscrypt.spec ./SRPMS/libscrypt-1.12-1.fc19.src.rpm libscrypt.src: W: spelling-error Summary(en_US) scrypt -> crypt, crypts, script libscrypt.src: W: spelling-error %description -l en_US scrypt -> crypt, crypts, script 1 packages and 1 specfiles checked; 0 errors, 2 warnings. Koji appeared to run well: http://koji.fedoraproject.org/koji/taskinfo?taskID=5691246 5691246 build (f19, libscrypt-1.12-1.fc19.src.rpm) completed successfully I've updated my testing reference to demonstrate Fedora as a confirmed installation: http://www.lolware.net/libscrypttesting.txt The spec file has been updated at the original URL: http://www.lolware.net/libscrypt.spec And a new version appropriate SRPM is here: http://www.lolware.net/libscrypt-1.12-1.fc19.src.rpm Many thanks for the review, hopefully I've addressed any concerns. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=E9K0nvY37b&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
