https://bugzilla.redhat.com/show_bug.cgi?id=990422



--- Comment #2 from Josef Stribny <jstri...@redhat.com> ---
* New upstream URL
  Please change the URL to: https://github.com/rails-api/rails-api

* Please include the license file from the official git repo to the main
package and open an upstream bug.

* Description should end up with a dot.

* Fix macro in comment by using two %% instead of one: %%gem_dir
  rubygem-rails-api.spec:52: W: macro-in-comment %gem_dir

Otherwise it looks okay, it builds and installs also with the upcoming update
of Rails 4.0, I was able to generate a new rails-api application, tests passed.
Please fix the above issues so I can approve.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=huSYMCIAuD&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to