https://bugzilla.redhat.com/show_bug.cgi?id=827723

Yaniv Bronhaim <bronh...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bronh...@gmail.com



--- Comment #14 from Yaniv Bronhaim <bronh...@gmail.com> ---
Hey, did an informal review and found the following issues:
1. instead of repeating "gnuhealth" hard-coded in the spec, you should use
%{name} - as you do with %{version}

2. when you use python source you should require BuildRequires: python2-devel
or python3-devel

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug 
https://bugzilla.redhat.com/token.cgi?t=tez6jeCRts&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to