https://bugzilla.redhat.com/show_bug.cgi?id=1000276
Mario Blättermann <mario.blaetterm...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|package-review@lists.fedora | |project.org | CC| |mario.blaetterm...@gmail.co | |m --- Comment #1 from Mario Blättermann <mario.blaetterm...@gmail.com> --- Please read the template contents before you submit a package for review: Remove the unneeded arch-dependent line from the header (the "sitearch" one). In general, this header is not needed anymore, unless you want to provide it for EPEL 5. See https://fedoraproject.org/wiki/Packaging:Python#Macros. # Remove CFLAGS=... for noarch packages (unneeded) Your package is noarch, so you can safely drop the CFLAGS statement (and also the comment in any case). BuildRequires: python-devel This is deprecated, use python2-devel instead. See https://fedoraproject.org/wiki/Packaging:Python#BuildRequires. %install rm -rf $RPM_BUILD_ROOT This is no longer needed. The initial cleaning of buildroot is default for a long time. The tarball bundles an egg-info (in ./src). You are forced to rebuild it from source; python-setuptools will do this job anyway. That's why remove that folder in %prep. See http://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Eggs. PKG-INFO says: Classifier: Programming Language :: Python :: 3 This module should also work with Python v3. Please install it for python3, too. Instead of simply repeating the summary in the description, you might use that one from the homepage (http://www.ros.org/wiki/wstool#wstool-1): "wstool provides commands to manage several local SCM repositories (supports git, mercurial, subversion, bazaar) based on a single workspace definition file (.rosinstall)." There's a spelling error in summary/description: heterogenous -> heterogeneous -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xLIamfqtZe&a=cc_unsubscribe _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review