https://bugzilla.redhat.com/show_bug.cgi?id=998459
--- Comment #2 from Mamoru TASAKA <mtas...@fedoraproject.org> ---
Some initial comments:
* MRI specfic Requires:
- Does "BuildRequires: ruby >= 1.8.7" mean that BR really
needs MRI ruby?
* Virtual (Build)Requires preferred
- Please use rubygem(rspec) instead of rubygem-rspec.
? Perhaps unneeded commands
- Please check if
cp -pr spec/ ./%{gem_instdir}
is really needed.
* Main documents
- At least "LICENSE.txt" should be main package, because
this contains license information
- Also I recommend to move "README.rdoc" to main, because
this is "README".
- _I_ would also move CHANGELOG.rdoc to main.
* Unwanted documents
- Files for test suite like spec/ should not be in
binary rpm: (see "Do not ship test" at below)
https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites
- Also "Rakefile" is something like "Makefile" in
autotool-based packages and usually this is not needed
in binary rpm.
? Duplicate review request
- Please contact the submitter of bug 886871 .
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=I7jqw8uU2A&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
