https://bugzilla.redhat.com/show_bug.cgi?id=1009742
Ralf Corsepius <rc040...@freenet.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rc040...@freenet.de
--- Comment #1 from Ralf Corsepius <rc040...@freenet.de> ---
* Fails to build in mock.
Please add:
BuildRequires: perl(Test::More)
* With the BR: above added, the testsuite skips a test.
Adding
BuildRequires: perl(Test::Expect)
causes the skipped test to be run.
* The License: field needs to be
License: GPL+ or Artistic
* Unless you intent to support EPEL5,
Group: ...
...
BuildRoot: %{_tmppath}/%{name}-%{version}-build
...
rm -rf $RPM_BUILD_ROOT
can all be removed.
* Macro usage is inconsistent:
%__perl and %{__perl} are both being used.
Please only use one of these (I recommend using %{__perl})
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=rpvzcA8n9C&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
