https://bugzilla.redhat.com/show_bug.cgi?id=1010557
--- Comment #5 from Satyajit Sahoo <satyajit.ha...@gmail.com> ---
I've fixed the issues you mentioned.
[!]: License field in the package spec file matches the actual license.
---> Changed license to GPLv3+.
[!]: Changelog in prescribed format.
---> Added version.
[!]: Each %files section contains %defattr if rpm < 4.4
---> Removed %defattr.
[!]: Spec file is legible and written in American English.
---> Sorry, no clue.
[!]: Package complies to the Packaging Guidelines
---> Probably it should now.
[!]: Packages should try to preserve timestamps of original installed files.
---> Used `%{__cp} -pr` instead of `%{__cp} -r`.
[!]: Spec use %global instead of %define unless justified.
---> Used %global instead of %define. Removed %{author}.
I've also splitted the package. But I still don't understand why I should split
the package. One who installs the GTK theme is expected to have both the GTK2
and GTK3 themes, coz new apps are mostly GTK3. And he would also need the
metacity themes, even if he uses Xfwm4, in case he uses compiz.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=kDQJtDm5gA&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
