https://bugzilla.redhat.com/show_bug.cgi?id=1009703
Christopher Meng <cicku...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cicku...@gmail.com
Summary|Review Request: RoboJournal |Review Request: roboJournal
|- Keep a journal/diary of |- Keep a journal/diary of
|day-to-day events in your |day-to-day events in your
|life |life
--- Comment #1 from Christopher Meng <cicku...@gmail.com> ---
Just a note, don't put subpackage information at the bottom.
######################################################################################################################
# RoboJournal Documentation Package SPEC (9/2/13)
%package doc
BuildArch: noarch
Summary: Documentation files for RoboJournal
Requires: qt-assistant, robojournal
%description doc
Documentation (compiled help file and collection file) for RoboJournal
%{version}.
%files doc
%{_defaultdocdir}/robojournal/robojournal.qhc
%{_defaultdocdir}/robojournal/robojournal.qch
Put them under %description of main package.
Also qmake-qt4 can be replaced by macro %qmake_qt4
${RPM_BUILD_ROOT} is weird, please use $RPM_BUILD_ROOT or %{buildroot}
%setup -q -n %{name}-%{version} can just be %setup -q
MUST NOT USE %{?_isa} IN BuildRequires!
See:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#BuildRequires_and_.25.7B_isa.7D
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=uOxFWicmRz&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
