https://bugzilla.redhat.com/show_bug.cgi?id=1011501
--- Comment #2 from Lubomir Rintel <lkund...@v3.sk> ---
(In reply to Christopher Meng from comment #1)
> No need to:
>
> Requires(post): /sbin/ldconfig
> Requires(postun): /sbin/ldconfig
Will remove that.
> Requires: %{name} = %{version}-%{release}
>
> Missing ?isa macro
Will fix.
> Please use github tag:
>
> https://github.com/hawaii-desktop/qt-accountsservice-addon/releases
>
> And rewrite the Source0 tag.
Umm, no. They have incorrect filenames, rendering use of ~/rpmbuild/SOURCES for
development of multiple packages useless.
> Please add a dot at the end of every %description.
Will fix
> %description(devel):
>
> Devel for Qt Account Service Addon
>
>
> is not good. Please change. (Devel is what when you see a -devel package? ;))
Will fix.
> Remove rm -rf $RPM_BUILD_ROOT
Will do.
> Remove %defattr(-,root,root,-)
Ditto.
> Keep docs in one line if you want.
I find it more readable as it is.
> %{_includedir}/qt5/QtAccountsService/*
>
> Unowned %{_includedir}/qt5/QtAccountsService itself
Will fix.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=cs55b93zOI&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
