https://bugzilla.redhat.com/show_bug.cgi?id=1018498

Johan Swensson <k...@kupo.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |k...@kupo.se



--- Comment #2 from Johan Swensson <k...@kupo.se> ---
I'm not a current package maintainer but here's an informal review:

$ rpmlint wondershaper1.2-1.fc19.noarch.rpm 
wondershaper.noarch: W: spelling-error Summary(en_US) shaper -> shape, sharper,
shapes
wondershaper.noarch: W: spelling-error %description -l en_US cablemodem ->
cable modem, cable-modem, demonstrable
wondershaper.noarch: E: incorrect-fsf-address
/usr/share/doc/wondershaper-1.2/COPYING
wondershaper.noarch: W: no-manual-page-for-binary wondershaper
1 packages and 0 specfiles checked; 1 errors, 3 warnings.

$ rpmlint wondershaper.spec 
wondershaper.spec: W: no-%build-section
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

Also:
%defattr(-,root,root,-) 

isn't needed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to