https://bugzilla.redhat.com/show_bug.cgi?id=1018859
Petr Pisar <ppi...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #4 from Petr Pisar <ppi...@redhat.com> ---
Spec file changes:
--- perl-Term-Clui.spec.old 2013-10-14 16:30:16.000000000 +0200
+++ perl-Term-Clui.spec 2013-10-16 18:53:57.000000000 +0200
@@ -1,22 +1,26 @@
Name: perl-Term-Clui
Version: 1.68
-Release: 1%{?dist}
-Summary: Term::Clui Perl module
+Release: 2%{?dist}
+Summary: Perl module offering a Command-Line User Interface
License: GPL+ or Artistic
Group: Development/Libraries
URL: http://search.cpan.org/dist/Term-Clui/
Source0:
http://www.cpan.org/authors/id/P/PJ/PJB/Term-Clui-%{version}.tar.gz
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildArch: noarch
BuildRequires: perl(ExtUtils::MakeMaker)
BuildRequires: perl(Term::ReadKey)
BuildRequires: perl(Term::ReadLine::Gnu)
BuildRequires: perl(Term::Size)
BuildRequires: perl(Test::Simple)
+BuildRequires: perl(Exporter)
+BuildRequires: perl(strict)
+BuildRequires: perl(warnings)
Requires: perl(Term::ReadKey)
Requires: perl(Term::ReadLine::Gnu)
Requires: perl(Term::Size)
-Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
+Requires: perl(strict)
+Requires: perl(warnings)
+Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo
$version))
%description
Term::Clui offers a high-level user interface to give the user of command-
@@ -30,33 +34,31 @@
%prep
%setup -q -n Term-Clui-%{version}
+#Don't pull in the examples dependencies
+chmod -x examples/*
%build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor
make %{?_smp_mflags}
%install
-rm -rf %{buildroot}
-
make pure_install PERL_INSTALL_ROOT=%{buildroot}
find %{buildroot} -type f -name .packlist -exec rm -f {} \;
-find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \;
%{_fixperms} %{buildroot}/*
%check
make test
-%clean
-rm -rf %{buildroot}
-
%files
-%defattr(-,root,root,-)
-%doc Changes README
+%doc Changes README examples
%{perl_vendorlib}/*
%{_mandir}/man3/*
%changelog
+* Wed Oct 16 2013 Kostas Georgiou <georg...@opengamma.com> 1.68-2
+- Review changes/fixes #1018859.
+
* Wed Oct 02 2013 Kostas Georgiou <georg...@opengamma.com> 1.68-1
- Specfile autogenerated by cpanspec 1.78.
> FIX: The summary is not descriptive. See README or Clui.pm for better text.
+Summary: Perl module offering a Command-Line User Interface
Ok.
> TODO: Remove the BuildRoot definition and cleaning in the %install section
> and remove the whole %clean section. They are not needed for Fedora.
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-rm -rf %{buildroot}
-%clean
-rm -rf %{buildroot}
Ok.
> TODO: You can replace `%{__perl}' macro with plain `perl' command.
Ok.
> > TODO: You can replace PERL_INSTALL_ROOT argument with standard DESTDIR
> > argument in the %install section.
> This doesn't seem to work:
> make pure_install
> DISTDIR=/builddir/build/BUILDROOT/perl-Term-Clui-1.68-2.fc21.x86_64
> ERROR: Can't create '/usr/share/man/man3'
> Do not have write permissions on '/usr/share/man/man3'
I guess you misspelled DESTDIR as DISTDIR.
> TODO: You can remove deleting empty directories in the %install section.
> ExtUtils::MakeMaker does not create empty directories anymore.
-find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \;
Ok.
> FIX: Remove %defattr macro from %files section. This is not needed anymore
> (since rpm-4.4).
-%defattr(-,root,root,-)
Ok.
> TODO: You could package the `example' subdirectory as a documentation.
-%doc Changes README
+%doc Changes README examples
Ok.
> FIX: Build-require `perl(Exporter)' (Clui.pm:13).
+BuildRequires: perl(Exporter)
Ok.
> TODO: Build-require `perl(strict)' (Clui.pm:20).
+BuildRequires: perl(strict)
Ok.
>TODO: Build-require `perl(warnings)' (Clui.pm:20).
+BuildRequires: perl(warnings)
Ok.
> TODO: Run-require `perl(strict)' (Clui.pm:20).
+Requires: perl(strict)
Ok.
> TODO: Run-require `perl(warnings)' (Clui.pm:20).
+Requires: perl(warnings)
Ok.
$ rpmlint perl-Term-Clui.spec ../SRPMS/perl-Term-Clui-1.68-2.fc21.src.rpm
../RPMS/noarch/perl-Term-Clui-1.68-2.fc21.noarch.rpm
perl-Term-Clui.src: W: spelling-error %description -l en_US summarised ->
summarized, summarize
perl-Term-Clui.src: W: spelling-error %description -l en_US pgp -> pg, pp, pep
perl-Term-Clui.src: W: spelling-error %description -l en_US rcs -> rs, cs, arcs
perl-Term-Clui.noarch: W: spelling-error %description -l en_US summarised ->
summarized, summarize
perl-Term-Clui.noarch: W: spelling-error %description -l en_US pgp -> pg, pp,
pep
perl-Term-Clui.noarch: W: spelling-error %description -l en_US rcs -> rs, cs,
arcs
2 packages and 1 specfiles checked; 0 errors, 6 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Term-Clui-1.68-2.fc21.noarch.rpm
drwxr-xr-x 2 root root 0 Oct 17 08:28
/usr/share/doc/perl-Term-Clui
-rw-r--r-- 1 root root 3848 Jul 3 02:59
/usr/share/doc/perl-Term-Clui/Changes
-rw-r--r-- 1 root root 3422 Nov 10 2010
/usr/share/doc/perl-Term-Clui/README
drwxr-xr-x 2 root root 0 Oct 17 08:28
/usr/share/doc/perl-Term-Clui/examples
-rw-r--r-- 1 root root 32203 Apr 11 2013
/usr/share/doc/perl-Term-Clui/examples/audio_stuff
-rw-r--r-- 1 root root 3256 Sep 27 2009
/usr/share/doc/perl-Term-Clui/examples/choose
-rw-r--r-- 1 root root 15558 Mar 18 2010
/usr/share/doc/perl-Term-Clui/examples/linux_admin
-rw-r--r-- 1 root root 5824 Mar 10 2012
/usr/share/doc/perl-Term-Clui/examples/login_shell
-rw-r--r-- 1 root root 8696 Mar 26 2012
/usr/share/doc/perl-Term-Clui/examples/test_script
-rw-r--r-- 1 root root 7715 Oct 17 08:28
/usr/share/man/man3/Term::Clui.3pm.gz
-rw-r--r-- 1 root root 3528 Oct 17 08:28
/usr/share/man/man3/Term::Clui::FileSelect.3pm.gz
drwxr-xr-x 2 root root 0 Oct 17 08:28
/usr/share/perl5/vendor_perl/Term
drwxr-xr-x 2 root root 0 Oct 17 08:28
/usr/share/perl5/vendor_perl/Term/Clui
-rw-r--r-- 1 root root 55522 Jul 3 10:48
/usr/share/perl5/vendor_perl/Term/Clui.pm
-rw-r--r-- 1 root root 9843 Mar 23 2013
/usr/share/perl5/vendor_perl/Term/Clui/FileSelect.pm
File permissions and layout are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Term-Clui-1.68-2.fc21.noarch.rpm |
sort -i | uniq -c
1 perl(:MODULE_COMPAT_5.18.1)
1 perl(Exporter)
1 perl(Term::ReadKey)
1 perl(Term::ReadLine::Gnu)
1 perl(Term::Size)
1 perl(strict)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Term-Clui-1.68-2.fc21.noarch.rpm
Binary dependencies resolvable. Ok.
Package builds in F21
(http://koji.fedoraproject.org/koji/taskinfo?taskID=6069374). Ok.
Package is good.
Please consider replacing the PERL_INSTALL_ROOT with DESTDIR before building
this package.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
