https://bugzilla.redhat.com/show_bug.cgi?id=1021721
--- Comment #10 from Erik Johnson <e...@saltstack.com> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #9)
> Group: → not necessary
>
At all, or is it still necessary for EPEL5?
> cd $RPM_BUILD_DIR/%{_realname}-%{version} → not necessary
>
Ah, so there is an implicit cd to the directory where the source was unpacked
(at least, in single-source builds)?
> Since you are also upstream for salttesting (judging by the email address):
> don't use bare 'except:' ever: it catches ^C. Not necessary, but it would be
> nice to fix.
>
Yeah, I haven't done any work with the test framework per se, I do most of my
work on salt proper. I did however just submit a pull request to get those bare
excepts changed (at least temporarily) to "except Exception".
> And also, can you include a license file upstream?
>
I brought up this point with the guy that manages the salt-testing project, and
by the end of this week we expect a 0.5.2 release to be cut, which will include
a LICENSE file.
> setup.py says Python 3 is alpha state... Are there any plans for full
> support? (See https://fedoraproject.org/wiki/Changes/Python_3_as_Default).
>
> Looks nice and clear.
Full support for Python 3 is expected in the next several months, M2Crypto is
still required to run salt and is the only real blocker, until we can move to
ZeroMQ 4 which includes its own crypto.
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
