https://bugzilla.redhat.com/show_bug.cgi?id=842107
Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zbys...@in.waw.pl
--- Comment #10 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
It seems that this review request is more advanced and up-to-date than
https://bugzilla.redhat.com/show_bug.cgi?id=838252.
+ License is OK.
+ Sources are OK.
+ Packaging looks mostly OK.
- Note: No known owner of /usr/share/locale/quz,
/usr/share/locale/ayc/LC_MESSAGES, /usr/share/locale/ayc,
/usr/share/locale/quz/LC_MESSAGES
- Name is not OK: I think the name from
https://bugzilla.redhat.com/show_bug.cgi?id=838252 (sugar-iknowamerica) is
better, or maybe sugar-conozcoamerica should be used.
- Can you extend the description a bit: what is the age level of the game, what
kind of a game it is, etc.
-
/usr/share/sugar/activities/IknowAmerica.activity/recursos/comun/fuentes/Share-Regular.ttf
is a font file and should be separated into a subpackage that this package
depends on (https://fedoraproject.org/wiki/Packaging:FontsPolicy). (Unless it
is packaged somewhere else, but I couldn't find it.)
--
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
