https://bugzilla.redhat.com/show_bug.cgi?id=1019435
--- Comment #2 from Lubomir Rintel <lkund...@v3.sk> --- Hi, thank you for your suggestions. (In reply to Eduardo Echeverria from comment #1) > Hi @Lkundrak: > > - Can you handle the Source url, under this scheme? > http://fedoraproject.org/wiki/Packaging:SourceURL#Github. I can not; that document is not up to date. Github no longer allows adding files to archive, nor provides a way to retrieve a sanely named tagged snapshot. I've raised a ticket about that to github, and there isn't much I could do about that until they fix their thing. > - Not is a blocker, but pkgconfig retrieve slowly dependencies, I would use > the name of the devel-packages The build system looks for pkgconfig files, so this is definitely more correct. It does not appear slow to me -- if it is slow for you it should probably be fixed in RPM instead. > - Why do you use ldconfig? I can't see any lib in $LDPATH root No good reason, I'll remove it. > - Please , don't use rm -rf $RPM_BUILD_ROOT after %install, It is just for > el5 packaging, Same applies for %defattr(-,root,root,-) Will do. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
