https://bugzilla.redhat.com/show_bug.cgi?id=1024993



--- Comment #6 from Lukash James <lukashja...@gmail.com> ---
(In reply to Antonio Trande from comment #5)
> Consider to leave a comment in the .spec file to describe the reasons of
> your choices, above all if they fall outside of packaging guidelines.
> 
> - You don't need of '%defattr(-, root, root)' line
> - Please remove the lines
> - Your package provides a .desktop file; validate it in a %check section.
> - Consider that starting from f20, every package docdir subdirectory will be
> unversioned.
Thank you for your comments, Antonio. I fixed all of them (I think) and updated
files in 'Description' section.
I have a question. Should I add new entries in %changelog if I fixed anything?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to