Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=596449

--- Comment #13 from Avesh Agarwal <avaga...@redhat.com> 2010-05-27 10:36:30 
EDT ---
(In reply to comment #10)
> You've attached tar.gz instead of src.rpm.
> Please put the updated .src.rpm to the fedorapeople web server as suggested by
> Chen Lei above.

Done: 

http://people.redhat.com/avagarwa/files/NetworkManager-openswan/

> 
> Note that you cannot comment out %define like you do:
> #%define snapshot .git20100411

> Macros are expanded in comments in .spec. You have to remove the %. Not that 
> it
> matters much.

Instead commenting it, I have included it to make it consistent with other
packages like NetworkManager-vpnc and NetworkManager-openvpn .


> 
> Also please add the COPYING file as %doc in %files.    
Done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to