Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=581279 Peter Lemenkov <lemen...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(lemen...@gmail.co | |m) | --- Comment #5 from Peter Lemenkov <lemen...@gmail.com> 2010-05-27 12:02:47 EDT --- (In reply to comment #4) > [+] PASS [-] FAIL [N/A] Not Applicable > > - MUST: rpmlint must be run on every package. The output should be posted in > the review. > > $ rpmlint erlang-ibrowse-1.5.6-2.fc13.src.rpm > erlang-ibrowse.src: W: invalid-url Source0: erlang-ibrowse-1.5.6.tar.bz2 > 1 packages and 0 specfiles checked; 0 errors, 1 warnings. > > The Source0 line needs to use the %{alphatag} naming format since you are > pulling from git. I see you're pulling from a git commit, but if there's a > tag > for the 1.5.6 release, that might be better to use. > https://fedoraproject.org/wiki/Packaging/NamingGuidelines#SnapshotPackages Done. I'm explicitly using git commit's name in tarball now. > - MUST: The License field in the package spec file must match the actual > license. > > The License field indicates 'BSD or LGPLv2' but it should be 'BSD and LGPLv2'. I'm afraid that you're wrong here. "ibrowse is available under two different licenses. LGPL and the BSD license." This sounds for me like ibrowse can be used either under LGPLv2+ (2+ is explicitly stated in the attached license) or under BSD. > - MUST: The spec file for the package MUST be legible. > > These are really just my own opinion. In general I think the spec file is > perfectly legible, but since we are in review, I figured I'd point out these > things: > > 1) The Requires: lines do not use a tab character to indent the value to the > 16th column like the Name through BuildRequires lines. Fixed. I added all these 'Requires' automatically, by using script, so this discrepancy can probably occur. > 2) The iconv line in the %prep section is long. I would suggest breaking up > the line because the spill over on an 80 column terminal makes the "rm -f > README.utf8" appear to be its own line, when really it's part of the entire > iconv line. Splitted in two lines. New srpm+spec: http://peter.fedorapeople.org/erlang-ibrowse.spec http://peter.fedorapeople.org/erlang-ibrowse-1.6.0-0.1.gita114ed3b.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
