https://bugzilla.redhat.com/show_bug.cgi?id=1000949

Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
(In reply to Christopher Meng from comment #3)
> The identical docs are needed as -gui is a dependent package which doesn't
> need to require main package:
> 
> %package        gui
> Summary:        GUI for %{name} based on Qt4
OK. But I think that the docs should not be *installed* twice. ttfautohint-gui
can contain stuff in /usr/share/docs/ttfautohint, so that the user doesn't get
a 1.5 MB hit on installing both. Just a suggestion.

> For the file-not-utf8 issue, I think it can be ignored.
OK.

> -----------------
> 
> Spec URL: http://cicku.me/ttfautohint.spec
> SRPM URL: http://cicku.me/ttfautohint-0.97-1.fc21.src.rpm

Package is APPROVED.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to