https://bugzilla.redhat.com/show_bug.cgi?id=1031342
Xavier Bachelot <xav...@bachelot.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |xav...@bachelot.org
--- Comment #7 from Xavier Bachelot <xav...@bachelot.org> ---
A couple comments on the spec :
- Remove the '%define version 1.0.0' line, use the Version: tag directly
instead.
- Swap the Summary: and Name: lines.
- Source: tag should be Source0:.
- About the URL tag, isn't there a better homepage than http://www.x.org ?
- Remove the %defattr line in the %files section, it's obsolete.
- In the changelog, add the release after the version.
Apart from these minor issues, the spec looks clean and it should be ready for
a formal review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
