https://bugzilla.redhat.com/show_bug.cgi?id=1032108



--- Comment #17 from Terje Røsten <terje...@phys.ntnu.no> ---
(In reply to Rex Dieter from comment #16)
> > yes I know but better be safe than sorry ;)
> 
> better to abide by the recommended guidelines:
> 
> https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/
> Guidelines#Explicit_Requires
> 
> "...  Packages must not contain unnecessary explicit Requires on libraries."
> that's a must, not a should, mind you. :)

Let me explain why: 

if e.g qt gets renamed to e.g qt5 you are in trouble, while with no explicit
deps you are fine.


>> Build is not verbose, not possible to verify build flags.
> What do you mean 'not verbose'? 

See e.g the line in logs:

Building CXX object src3party/qxt/CMakeFiles/qxt.dir/qxtglobal.cpp.o

There is no information here about build flags used. 

Change
make %{?_smp_mflags} -C %{_target_platform}
to
make %{?_smp_mflags} -C %{_target_platform} VERBOSE=1

to see the difference. You will then see an other problem, correct build flags
are not used. 

See:
 https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to