https://bugzilla.redhat.com/show_bug.cgi?id=1033961



--- Comment #8 from Christopher Meng <cicku...@gmail.com> ---
1. Please sort your spec for readability:

Move:

BuildRequires:  python-setuptools python-sphinx fdupes fontconfig tmux
vim-minimal
BuildArch: noarch

after

Url:            https://github.com/Lokaltog/powerline

2. 
%define checkout 20131123gitdb80fc

-->


%global checkout 20131123gitdb80fc

And ask upstream to tag the project.

3. %build

Add a note like 

#nothing to build.

4. install with -p option to preserve the timestamp.

5. %fdupes %{buildroot}%{python_sitelib}

What's this crap?

6. Just one line in %files:

%{_datadir}/%{name}

No need to 

%dir %{_datadir}/%{name}
%{_datadir}/%{name}/fontpatcher-symbols.sfd

7. python setup.py install --prefix=%{_prefix} --root=%{buildroot} --optimize=1

Use:

%{__python2} setup.py install --prefix=%{_prefix} --root=%{buildroot}
--optimize=1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to