https://bugzilla.redhat.com/show_bug.cgi?id=1032186
--- Comment #6 from Mamoru TASAKA <mtas...@fedoraproject.org> ---
Some other comments:
* Unpacking tarball in %prep
----------------------------------------------------
49 %setup -q -D -T -n %{gem_name}-%{version}
53 tar -xJf %{SOURCE2}
----------------------------------------------------
- I guess "%setup -q -D -T -n %{gem_name}-%{version} -a 2" is
better.
* For Source1
- It is better to add "set -e"
- And I would remove rack-openid-$VERSION.zip (not a blocker)
- Also it is better to suppress this rpmlint:
-----------------------------------------------------
rubygem-rack-openid.src: W: strange-permission
rubygem-rack-openid-generate-test-tarball.sh 0775L
-----------------------------------------------------
Please check the comments above, and also your previous comments.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
