https://bugzilla.redhat.com/show_bug.cgi?id=987738
František Dvořák <val...@civ.zcu.cz> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |val...@civ.zcu.cz
--- Comment #6 from František Dvořák <val...@civ.zcu.cz> ---
My observations:
1) description could be improved
Inspiration can be found in upstream:
http://anonscm.debian.org/gitweb/?p=collab-maint/dput.git;a=blob;f=debian/control;hb=HEAD
.
2) license: there are "and above" in copyright notices, I think it should be
GPLv2+
3) incorrect FSF address in /usr/bin/dput and /usr/bin/dcut, upstream should be
notified
4) missing build requires python2-devel or python3-devel
Here it is not so clear, what to do with it.
There are *.py and *.pyc files in /usr/share/dput/, and this directory doesn't
distinguish the python version. Proper directory could be %{python_sitelib} or
%{python3_sitelib}, but these files are used as "plugins" and the code expects
them in /usr/share/dput. Am I right these files should remain there? (I'm not
python programmer.)
I that case it could be just used python-devel as the build dependency (= using
default python BR).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
