https://bugzilla.redhat.com/show_bug.cgi?id=1011485



--- Comment #1 from Michal Schmidt <mschm...@redhat.com> ---
> Group: Development/Tools

The "Group" tag is not mandatory, but you can keep it if you want (for
compatibility with EPEL).
http://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag

> License: GPLv2+ and BSD

Looking in the tarball I found it's actually GPL v3 or higher.

I'm not sure what parts are supposed to be under the BSD license. Hm, it looks
like the upstream tarball bundles several independent libraries. That's frowned
upon in Fedora. Please try to remove the bundled stuff in the %prep step and
see if it builds and works fine with the system libraries.
http://fedoraproject.org/wiki/Packaging:Guidelines#Duplication_of_system_libraries

> %defattr(-,root,root,-)

It should no longer be needed to specify this explicitly.
http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to