https://bugzilla.redhat.com/show_bug.cgi?id=1027784
--- Comment #12 from Jon Ciesla <limburg...@gmail.com> ---
- rpmlint checks return:
gnome-logs.x86_64: W: spelling-error Summary(en_US) systemd -> systems, system,
system d
The value of this tag appears to be misspelled. Please double-check.
gnome-logs.x86_64: W: spelling-error %description -l en_US systemd -> systems,
system, system d
The value of this tag appears to be misspelled. Please double-check.
Ignore these.
gnome-logs.x86_64: W: no-manual-page-for-binary gnome-logs
Each executable in standard binary directories should have a man page.
Nice to have, but. . .
- package meets naming guidelines
- package meets packaging guidelines
- license ( GPLv3+ ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
! no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
BR problem, output of mock build:
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh
/builddir/build/BUILD/gnome-logs-3.11.2/build-aux/missing autoconf
cd . && /bin/sh /builddir/build/BUILD/gnome-logs-3.11.2/build-aux/missing
automake-1.13 --gnu
/builddir/build/BUILD/gnome-logs-3.11.2/build-aux/missing: line 81:
automake-1.13: command not found
WARNING: 'automake-1.13' is missing on your system.
You should only need it if you modified 'Makefile.am' or
'configure.ac' or m4 files included by 'configure.ac'.
The 'automake' program is part of the GNU Automake package:
<http://www.gnu.org/software/automake>
It also requires GNU Autoconf, GNU m4 and Perl in order to run:
<http://www.gnu.org/software/autoconf>
<http://www.gnu.org/software/m4/>
<http://www.perl.org/>
make: *** [Makefile.in] Error 1
make: *** Waiting for unfinished jobs....
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.MMUs5T (%build)
Bad exit status from /var/tmp/rpm-tmp.MMUs5T (%build)
Child return code was: 1
EXCEPTION: Command failed. See logs for output.
# ['bash', '--login', '-c', 'rpmbuild -bb --target i686 --nodeps
builddir/build/SPECS/gnome-logs.spec']
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line
70, in trace
result = func(*args, **kw)
File "/usr/lib/python2.7/site-packages/mockbuild/util.py", line 376, in do
raise mockbuild.exception.Error, ("Command failed. See logs for output.\n #
%s" % (command,), child.returncode)
Error: Command failed. See logs for output.
# ['bash', '--login', '-c', 'rpmbuild -bb --target i686 --nodeps
builddir/build/SPECS/gnome-logs.spec']
LEAVE do --> EXCEPTION RAISED
Otherwise it looks OK.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
