https://bugzilla.redhat.com/show_bug.cgi?id=924682
--- Comment #7 from Palle Ravn <ravn...@gmail.com> ---
(In reply to Christopher Meng from comment #6)
> 1. You need to request a license file from upstream and ship it in the
> tarball
I have emailed Samuel Elsamuko and awaiting his response.
> 2. %{_datarootdir} -> %{_datadir}
Done.
> 3. Add a comment in %build like "Nothing to build" to indicate that no need
> to build anything here.
I find it self explaining, but added it anyway.
> 4. If you don't have any special need, you should remove threaded blank
> lines.
It's a topic for endless debate. I use 2 empty lines in all my SPEC files, and
I will continue doing so. "All RPM sections, starting from %description, should
be separated by two empty lines." -cite
http://fedoraproject.org/wiki/PeterGordon/SpecFormattingGuidelines
The new SPEC and RPM files are hosted at gimp-elsamuko.zom.dk
--
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
