https://bugzilla.redhat.com/show_bug.cgi?id=1045476
--- Comment #5 from Cristian Ciupitu <cristian.ciup...@yahoo.com> ---
$ rpmlint dnf-plugins-core.spec
dnf-plugins-core.spec: W: no-%build-section
$ rpmlint dnf-plugins-core-0.0.1-1.fc20.src.rpm
dnf-plugins-core.src: W: strange-permission dnf-plugins-core.spec 0600L
dnf-plugins-core.src: W: strange-permission dnf-plugins-core-561c107.tar.xz
0600L
dnf-plugins-core.src: W: no-%build-section
I suggest using 644 for the permissions to get rid of the warnings and
adding an empty %build section or comment saying it's not needed.
A couple of other nitpicks:
- replace $RPM_BUILD_ROOT with %{buildroot} for extra consistency;
- the URL for Souce0 is invalid (404). If you decide for a Github URL
see https://fedoraproject.org/wiki/Packaging:SourceURL#Github .
For example
https://github.com/akozumpl/dnf-plugins-core/archive/561c107e11e6c560866a0cb5c3cd181240f825bf/dnf-plugins-core-0.0.1-561c107e11.tar.bz2
works fine;
- the release and the changelog should probably be updated for every
change so that the reviewers and submitter can be sure they're
talking about the same thing. I'm saying this because you've probably
changed something after the first comment and the release number is
still 1.
(In reply to Ralf Corsepius from comment #4)
> (In reply to Cristian Ciupitu from comment #3)
> > From what I understood on IRC, Fedora 19 is not supported anymore, so I
> > won't review it.
> Not quite. F18 is going EOL soon (IIRC, Jan 14th). F19 will still be
> supported for ca. 1/2 year.
I was referring to to this new package. It doesn't have to support
Fedora 19 if the author doesn't want to.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
