https://bugzilla.redhat.com/show_bug.cgi?id=1048966
Antonio Trande <anto.tra...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |anto.tra...@gmail.com
--- Comment #1 from Antonio Trande <anto.tra...@gmail.com> ---
Hi Francesco.
Just few comments.
- Description has too long lines.
- Documentation files (above all the license file) are missing; the source
archive provides them. ;)
See http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation
- %doc %{_mandir}/man1/seren.1.gz
Don't mark this line as %doc.
- Where did you take that patch from ? Does it come from upstream or is it your
?
Please leave a comment or a link.
http://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment
- Changelog already starts with a release number 2 ?
http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
