https://bugzilla.redhat.com/show_bug.cgi?id=1048493
Denis Fateyev <de...@fateyev.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ke...@scrye.com
Assignee|nob...@fedoraproject.org |de...@fateyev.com
Flags| |needinfo?(ke...@scrye.com)
--- Comment #5 from Denis Fateyev <de...@fateyev.com> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[?]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "GPL", "LGPL (v2.1 or later) (with
incorrect FSF address)", "BSD (3 clause) ISC", "LGPL (v2 or later) (with
incorrect FSF address)", "Apache (v2.0) BSD (2 clause)", "ISC", "Public
domain", "GPL (v3 or later)", "zlib/libpng", "libpng", "BSD (2 clause)",
"Apache (v2.0)", "GPL (v2 or later)", "MIT/X11 (BSD like)", "MPL (v1.1)",
"*No copyright* Public domain", "BSD (4 clause) ISC", "BSD (3 clause)",
"MPL (v1.1) GPL (unversioned/unknown version)", "LGPL", "Unknown or
generated", "BSD (4 clause)", "BSL (v1.0)", "*No copyright* GPL (v3 or
later)", "MPL (v1.0) LGPL (v2 or later) (with incorrect FSF address)",
"*No copyright* Beerware", "Apache (v2.0) MIT/X11 (BSD like)", "LGPL
(v2.1 or later)", "BSD (3 clause) MIT/X11 (BSD like)". 18480 files have
unknown license. Detailed output of licensecheck in
/home/mock/sandbox/prebuilt/icecat/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: Using prebuilt rpms.
[?]: Package contains no bundled libraries without FPC exception.
Note: Especially check following dirs for bundled code:
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/signaling/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/testing/mozbase/manifestdestiny/tests/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/modules/audio_processing/aec/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/test/libtest/include,
/home/mock/sandbox/prebuilt/icecat/upstream-unpacked/Source0/icecat-24.0
/addon-sdk/source/python-lib/cuddlefish/tests/static-
files/packages/third_party, /home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/ipc/chromium/src/third_party,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/modules/audio_device/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/js/src/ctypes/libffi/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/testing/gtest/gmock/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/modules/video_capture/external,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/libnestegg/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/modules/video_render/external,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/netwerk/srtp/src/crypto/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/tools/gyp/test/rules/src/external,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/libtheora/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/gfx/ots/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/modules/audio_coding/codecs/g711/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/common_audio/resampler/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/security/nss/lib/libpkix/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/browser/branding/unofficial/extensions/jid1-KtlZuoiikVfFew@jetpack/resources/librejs/data/third_party,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/omx-plugin/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/modules/audio_processing/agc/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/signaling/src/sipcc/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/gfx/angle/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/netwerk/srtp/src/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/python/mozbuild/mozbuild/test/backend/data/external_make_dirs/external,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/security/nss/lib/dbm/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/modules/video_coding/codecs/vp8/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/modules/remote_bitrate_estimator/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/nsprpub/pr/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/modules/video_capture/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/signaling/src/sipcc/cpr/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/video_engine/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/testing/gtest/gtest/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/ipc/chromium/src/base/third_party,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/modules/audio_processing/aecm/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webvtt/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/toolkit/crashreporter/google-
breakpad/src/common/android/include, /home/mock/sandbox/prebuilt/icecat
/upstream-unpacked/Source0/icecat-24.0/gfx/angle/src/third_party,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/toolkit/crashreporter/google-
breakpad/src/common/android/testing/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/testing/gtest/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/tools/gyp/test/mac/libraries,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/toolkit/crashreporter/google-
breakpad/src/third_party, /home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/common_audio/vad/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/voice_engine/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/libtremor/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/libvpx/vpx_mem/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/memory/jemalloc/src/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/libopus/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/common_audio/signal_processing/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/modules/freetype2/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/mtransport/third_party,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/modules/bitrate_controller/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/third_party,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/libvorbis/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/libogg/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/modules/audio_processing/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/modules/audio_processing/ns/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/libcubeb/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/nsprpub/lib/libc/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/video_engine/test/libvietest/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/common_video/libyuv/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/gfx/graphite2/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/modules/audio_coding/codecs/g722/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/modules/freetype2/builds/amiga/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/gfx/skia/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/modules/pacing/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/caps/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/modules/audio_coding/codecs/cng/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/modules/video_render/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/common_video/jpeg/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/media/webrtc/trunk/webrtc/modules/audio_coding/codecs/pcm16b/include,
/home/mock/sandbox/prebuilt/icecat/upstream-
unpacked/Source0/icecat-24.0/xpcom/tests/external
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package does not contain duplicates in %files.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 163840 bytes in 12 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
Note: Arch-ed rpms have a total of 8622080 bytes in /usr/share
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
Rpmlint
-------
Checking: icecat-24.0-2.fc19.src.rpm
icecat.src: W: strange-permission icecat-24.0.tar.gz 0600L
icecat.src: W: strange-permission icecat-disable-neon.patch 0600L
icecat.src: W: %ifarch-applied-patch Patch1: %{name}-disable-neon.patch
icecat.src: W: invalid-url Source4: icecat-langpacks.tar.gz
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
Rpmlint (installed packages)
----------------------------
[mock@fc19-amd64 icecat]$ rpmlint icecat
icecat.x86_64: W: obsolete-not-provided mozilla
icecat.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/icecat-24.0/icecat
['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/libmozsqlite3.so ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/icecat-bin ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/mozilla-xremote-client ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/components/libmozgnome.so ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/browser/components/libbrowsercomps.so ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/libmozalloc.so ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/components/libdbusservice.so ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/libxul.so ['%{mozappdir}']
icecat.x86_64: E: missing-call-to-setgroups /usr/lib64/icecat-24.0/libxul.so
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/xulrunner-stub ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/webapprt-stub ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/plugin-container ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/xulrunner ['%{mozappdir}']
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/inspector/selector-search.js
icecat.x86_64: E: wrong-script-end-of-line-encoding
/usr/lib64/icecat-24.0/browser/modules/devtools/inspector/selector-search.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/extensions/privacy_featu...@gnuzilla.gnu.org/chrome/locale/es-AR/privacy_features.properties
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/VariablesViewController.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/Parser.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/StyleSheetEditor.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/profiler/cleopatra/css/ui.css
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/components/NetworkGeolocationProvider.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/modules/devtools/gcli.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/modules/devtools/SourceMap.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/framework/toolbox.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/DeveloperToolbar.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/inspector/highlighter.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/StyleEditorDebuggee.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/chrome/en-US/locale/browser/devtools/tilt.properties
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/styleinspector/css-logic.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/tilt/tilt-utils.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/profiler/cleopatra/images/circlearrow.svg
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/markupview/markup-view.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/shared/telemetry.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/modules/osfile/osfile_win_allthreads.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/modules/osfile/osfile_unix_allthreads.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/ProfilerPanel.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/SplitView.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/gDevTools.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/modules/osfile/_PromiseWorker.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/AppCacheUtils.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/BuiltinCommands.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/modules/osfile/osfile_async_front.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/ViewHelpers.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/main.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/inspector/selection.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/LayoutHelpers.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/tilt/TiltWorkerCrafter.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/framework/webconsole.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/DebuggerProcess.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/modules/osfile/osfile_shared_front.jsm
icecat.x86_64: E: incorrect-fsf-address
/usr/lib64/icecat-24.0/browser/extensions/https-everywh...@eff.org/chrome/content/code/NSS.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/modules/osfile/osfile_win_back.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/modules/osfile/ospath_unix_back.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/CmdTilt.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/ProfilerHelpers.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/modules/osfile/osfile_async_worker.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/tilt/tilt-visualizer.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/shared/undo.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/ProfilerController.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/tilt/TiltWorkerPicker.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/CmdScratchpad.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/StyleEditorPanel.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/responsivedesign.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/framework/toolbox-options.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/framework/toolbox-hosts.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/styleinspector/rule-view.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/profiler/cleopatra/css/tree.css
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/modules/devtools/Templater.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/profiler/cleopatra/js/ProgressReporter.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/shared/inplace-editor.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/modules/osfile/osfile_shared_allthreads.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/DOMHelpers.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/modules/osfile/osfile_unix_back.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/DebuggerPanel.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/CmdInspect.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/cleopatra.html
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/profiler/cleopatra/js/parser.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/tilt/tilt-gl.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/modules/osfile/osfile_unix_front.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/FloatingScrollbars.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/shared/event-emitter.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/CmdEdit.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/framework/sidebar.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/tilt/tilt-visualizer-style.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/modules/osfile/osfile_win_front.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/profiler/cleopatra/images/throbber.svg
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/StyleEditorUI.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/AutocompletePopup.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/tabview/utils.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/scratchpad-manager.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/VariablesView.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/inspector/breadcrumbs.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/profiler/cleopatra/images/treetwisty.svg
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/modules/osfile/ospath_win_back.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/profiler/cleopatra/js/parserWorker.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/styleinspector/computed-view.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/inspector/inspector-panel.js
icecat.x86_64: E: zero-length
/usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/profiler/cleopatra/images/noise.png
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/shared/theme-switching.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/CmdResize.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/profiler/cleopatra/js/tree.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/gcli.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/chrome/browser/content/browser/devtools/profiler/cleopatra/js/ui.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/modules/Promise.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/tilt/tilt.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/Commands.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/cmd-profiler.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/framework/target.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/StyleEditorUtil.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/BreadcrumbsWidget.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/tilt/tilt-math.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/styleinspector/style-inspector.js
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/CmdDebugger.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/NetMonitorPanel.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/SideMenuWidget.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/browser/modules/devtools/Jsbeautify.jsm
icecat.x86_64: E: script-without-shebang
/usr/lib64/icecat-24.0/chrome/en-US/locale/en-US/pipnss/pipnss.properties
icecat.x86_64: W: no-manual-page-for-binary icecat
1 packages and 0 specfiles checked; 118 errors, 2 warnings.
Requires
--------
icecat (glibc, rpmlib filtered):
/bin/bash
/bin/sh
fedora-bookmarks
libX11.so.6()(64bit)
libXext.so.6()(64bit)
libXrender.so.1()(64bit)
libXt.so.6()(64bit)
libasound.so.2()(64bit)
libasound.so.2(ALSA_0.9)(64bit)
libasound.so.2(ALSA_0.9.0rc4)(64bit)
libatk-1.0.so.0()(64bit)
libcairo.so.2()(64bit)
libdbus-1.so.3()(64bit)
libdbus-glib-1.so.2()(64bit)
libdl.so.2()(64bit)
libfontconfig.so.1()(64bit)
libfreetype.so.6()(64bit)
libgcc_s.so.1()(64bit)
libgdk-x11-2.0.so.0()(64bit)
libgdk_pixbuf-2.0.so.0()(64bit)
libgio-2.0.so.0()(64bit)
libglib-2.0.so.0()(64bit)
libgobject-2.0.so.0()(64bit)
libgthread-2.0.so.0()(64bit)
libgtk-x11-2.0.so.0()(64bit)
libhunspell-1.3.so.0()(64bit)
libm.so.6()(64bit)
libmozalloc.so()(64bit)
libmozsqlite3.so()(64bit)
libnspr4.so()(64bit)
libnss3.so()(64bit)
libnss3.so(NSS_3.10)(64bit)
libnss3.so(NSS_3.10.2)(64bit)
libnss3.so(NSS_3.11)(64bit)
libnss3.so(NSS_3.11.1)(64bit)
libnss3.so(NSS_3.11.7)(64bit)
libnss3.so(NSS_3.12)(64bit)
libnss3.so(NSS_3.12.3)(64bit)
libnss3.so(NSS_3.12.9)(64bit)
libnss3.so(NSS_3.13)(64bit)
libnss3.so(NSS_3.2)(64bit)
libnss3.so(NSS_3.3)(64bit)
libnss3.so(NSS_3.4)(64bit)
libnss3.so(NSS_3.5)(64bit)
libnss3.so(NSS_3.6)(64bit)
libnss3.so(NSS_3.7)(64bit)
libnss3.so(NSS_3.9)(64bit)
libnss3.so(NSS_3.9.2)(64bit)
libnss3.so(NSS_3.9.3)(64bit)
libnssutil3.so()(64bit)
libnssutil3.so(NSSUTIL_3.12)(64bit)
libnssutil3.so(NSSUTIL_3.12.3)(64bit)
libnssutil3.so(NSSUTIL_3.13)(64bit)
libpango-1.0.so.0()(64bit)
libpangocairo-1.0.so.0()(64bit)
libpangoft2-1.0.so.0()(64bit)
libplc4.so()(64bit)
libplds4.so()(64bit)
libpthread.so.0()(64bit)
librt.so.1()(64bit)
libsmime3.so()(64bit)
libsmime3.so(NSS_3.13)(64bit)
libsmime3.so(NSS_3.15)(64bit)
libsmime3.so(NSS_3.2)(64bit)
libsmime3.so(NSS_3.3)(64bit)
libsmime3.so(NSS_3.4)(64bit)
libsmime3.so(NSS_3.4.1)(64bit)
libsmime3.so(NSS_3.6)(64bit)
libsmime3.so(NSS_3.9.3)(64bit)
libssl3.so()(64bit)
libssl3.so(NSS_3.12.6)(64bit)
libssl3.so(NSS_3.13)(64bit)
libssl3.so(NSS_3.13.2)(64bit)
libssl3.so(NSS_3.14)(64bit)
libssl3.so(NSS_3.2)(64bit)
libssl3.so(NSS_3.4)(64bit)
libvpx.so.1()(64bit)
libxul.so()(64bit)
libxul.so(xul24.0)(64bit)
libz.so.1()(64bit)
rtld(GNU_HASH)
icecat-devel (glibc, rpmlib filtered):
/bin/sh
/usr/bin/env
/usr/bin/pkg-config
icecat(x86-64) = 24.0-2.fc19
pkgconfig(nspr) >= 4.10.2
Provides
--------
icecat:
icecat
icecat(x86-64)
libbrowsercomps.so()(64bit)
libbrowsercomps.so(EXPORTED)(64bit)
libdbusservice.so()(64bit)
libdbusservice.so(EXPORTED)(64bit)
libmozalloc.so()(64bit)
libmozgnome.so()(64bit)
libmozgnome.so(EXPORTED)(64bit)
libmozsqlite3.so()(64bit)
libxul.so()(64bit)
libxul.so(xul24.0)(64bit)
mimehandler(application/vnd.mozilla.xul+xml)
mimehandler(application/xhtml+xml)
mimehandler(text/html)
mimehandler(text/mml)
mimehandler(text/xml)
mimehandler(x-scheme-handler/http)
mimehandler(x-scheme-handler/https)
webclient
icecat-devel:
icecat-devel
icecat-devel(x86-64)
icecat-static
pkgconfig(libxul)
pkgconfig(libxul-embedding)
pkgconfig(mozilla-js)
pkgconfig(mozilla-plugin)
Source checksums
----------------
http://ftp.gnu.org/gnu/gnuzilla/24/icecat-24.0.tar.gz :
CHECKSUM(SHA256) this package :
2a79e6db8831a4047030a0451036a34a97fde455fba7a949efde34052b97bfef
CHECKSUM(SHA256) upstream package :
2a79e6db8831a4047030a0451036a34a97fde455fba7a949efde34052b97bfef
Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review --rpm-spec --prebuilt --define DISTTAG=f19
-v --name icecat
Buildroot used: fedora-19-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH
----------------------------
Now review notes:
Koji scratch builds used:
https://koji.fedoraproject.org/koji/taskinfo?taskID=6390515 (Fedora 19)
https://koji.fedoraproject.org/koji/taskinfo?taskID=6390802 (Rawhide)
1) Still unsure about License tag: probably, this format in spec is allowed,
but I'm unsure. Marked as "non-evaluated" for now, it requires more
clarification. "Firefox" and "xulrunner" both use simplified tag;
2) "Package contains no bundled libraries without FPC exception" - have no idea
whether it's actual here, could you check them, or clear the issue providing
more details?
3) Multiple issues with "%{mozappdir}" should be sorted;
4) Why not to use "xulrunner" already packaged in Fedora?
5) Approval status in uncertain due the issue mentioned in the first post:
"Some time ago I read that icecat can not be included officially in Fedora
because a "Firefox browser" already exists."
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
