https://bugzilla.redhat.com/show_bug.cgi?id=1051901
--- Comment #5 from Vít Ondruch <vondr...@redhat.com> ---
* Bump release
- It is good habit to bump release for each review cycle. It is easier to see
changes and compare with previous version, if needed.
* Don't mark test and Rakefile by %doc macro
- They are not documentation, therefore they should not be marked by %doc
documentation.
- Some even thinks that nothing in -doc subpackage should be marked by as
%doc, but I am not in that camp ;) So take it just as a remark.
* Remove test and Rakefile from main package
- You keep them twice now. Please remove them from the main package and leave
them just in -doc subpackage
* rpmlint
- rpmlint complains about wrong-file-end-of-line-encoding a lot. This might
be
better to check with upstream.
- rubygem-rgen-doc.noarch: W: file-not-utf8 /usr/share/gems/gems/rgen-
0.6.6/test/testmodel/ea_testmodel.xml error seems to be false positive,
since the XML explicitly says it is windows-1252 encoded. Probably nothing
we can do about it.
* Test suite
- Please execute the test suite during build.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
