https://bugzilla.redhat.com/show_bug.cgi?id=1005782



--- Comment #6 from Michael Simacek <msima...@redhat.com> ---
Few issues before doing in-depth review:
- icons are licensed under BSD (according to LICENSE file) -> License should be
ASL 2.0 and BSD
- there is a NOTICE file, which could possibly affect packages licensing.
  I sent an email to Fedora legal mailing-list to get this sorted out.

some rpmlint warnings:
uimaj.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/uimaj/NOTICE
uimaj.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/uimaj/README
jcasgen-maven-plugin.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/jcasgen-maven-plugin/NOTICE
uima-pear-maven-plugin.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/uima-pear-maven-plugin/NOTICE
uimaj-javadoc.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/uimaj-javadoc/NOTICE 


And a few questions:
Why do you remove that "eclipse stuff"? You should include a reason in the
comment above it.
Why do you remove apache-rat-plugin?
Those scripts suggest that some parts could be directly executed by user. Why
don't you install them or (better) provide %jpackage_script alternatives?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to