Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591365 Martin Gieseking <martin.giesek...@uos.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.giesek...@uos.de --- Comment #1 from Martin Gieseking <martin.giesek...@uos.de> 2010-06-04 03:56:21 EDT --- Hi Eric, some quick comments: - unlike your comment in the spec file, the regular SF download URL works, so you should change Source0 to https://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz - The intended license seems to be LGPLv3+. However the sources in libexplain/iocontrol refer to GPL3+. That would result in GPL3+. You should ask upstream if this is intentional or a mistake. In the latter case the comment headers should be fixed. - the package fails to build in mock and koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2229164 This is because there are some includes missing, e.g. in libexplain/buffer/ifreq_data/hwtstamp_config.c: #include <libexplain/parse_bits.h> in libexplain/iocontrol/siocshwtstamp.c: #include <libexplain/path_is_efault.h> I didn't try to find all. There are some more includes missing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
