Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=599097 --- Comment #10 from Ankur Sinha <sanjay.an...@gmail.com> 2010-06-05 01:21:47 EDT --- (In reply to comment #9) > (In reply to comment #8) > > - %{_includedir}/* is a bit too generic. Replace it with > > %{_includedir}/gexiv2/ > > I would say the same thing about > %{_libdir}/*.so > and > %{_libdir}/*.so.* > since I'd guess there is only one or a couple of libraries that are installed, > so I usually recommend filling in these in more precision, e.g. > %{_libdir}/libfoo.so > and > %{_libdir}/libfoo.so.* > > Also, I think -devel should Requires: vala for dir ownership, as there is a > file put in %{_datadir}/vala/vapi/. (In reply to comment #8) > Hi Ankur, here are some more remarks about your spec file: > > - add a short comment above Patch0 telling what the patch does > > - you can simplify calling the configure configure script as follows: > echo '%{configure}' | sed '/--program-prefix=/d' >configure.new > sh configure.new > This also fixes the rpmlint warning about a missing libdir specification > > - it's not necessary to remove the empty files as they are not listed in %doc > and thus not packaged > > - drop the %doc files from the -devel package (the files should only be added > once) > > - %{_includedir}/* is a bit too generic. Replace it with > %{_includedir}/gexiv2/ hey, I've fixed these (at least I think so) * Sat Jun 05 2010 Ankur Sinha <ankursinha AT fedoraproject DOT org> - 0.0.90-4 - changed configure portion - added Requires: vala for devel - made the file section more precise - bugzilla #599097 - changed patch to include a default LIB setting http://ankursinha.fedorapeople.org/libgexiv2/libgexiv2.spec http://ankursinha.fedorapeople.org/libgexiv2/libgexiv2-0.0.90-4.fc13.src.rpm rest of the mock build stuff at: http://ankursinha.fedorapeople.org/libgexiv2/ regards, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
