https://bugzilla.redhat.com/show_bug.cgi?id=1057849
--- Comment #3 from Michael Schwendt <bugs.mich...@gmx.net> --- > We should avoid using %attr nowadays. Not only "nowadays". It's been a recommendation for a very long time to fix ordinary permissions with a patch to a Makefile or in %install with chmod or install -m, and to get the problem fixed in the upstream source, too (so future releases won't install additional files with wrong permissions). It's widely accepted practise to restrict usage of %attr to setting really special/unusual permissions (e.g. setuid, setgid, g-rx) and owner/group changes, so special attributes set with %attr really stick out (especially when using syntax highlighting). There's nothing in the packaging guidelines about it. In packages with many more files and directories, if you needed to "fix" permissions, overusing %attr would reduce readability of the spec file a lot. However, if a packager insists on using %attr to fix ordinary permissions, that is acceptable. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
