https://bugzilla.redhat.com/show_bug.cgi?id=1020942



--- Comment #18 from Jeremy Newton <alexjn...@gmail.com> ---
(In reply to Richard Shaw from comment #17)
> Ok, a couple of questions/differences about your spec...
> 
> 1. You move the bakefiles but Dan's spec mentions that they're not supported
> and just deletes them.

Hmm that's a good question, because if I understand correctly those bakefiles
are supported, but I'll remove them and re-add them if necessary in the future.

> 2. I've got the compat26 option enabled right now... I'm not sure we need it
> since 2.8 should have this enabled...

Agreed, plus this flag seems to cause an odd build fail on f20, so I've deemed
this as a non-issue.

> 3. I'm building against GTK3 instead of GTK2 but I'm assuming that's OK with
> you.

I'll make this change, I've just been busy but I have some time today to finish
this off so it can be reviewed.

As for the wx-config, I purpose that patching should be the method for the time
being; if a more elegant solution is necessary, this issue can be
re-approached.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to